Fix #2028: Suppress false unsaved changes prompt when loading a deck by kellyelton · Pull Request #2297 · octgn/OCTGN

kellyelton · 2026-03-25T15:52:34Z

Loading a deck with notes triggers the TextBox's TextChanged event, which sets _unsaved = true even though the user hasn't made any changes. Added an _isLoading flag that suppresses the dirty state during deck loading.

Fixes #2028

…in the editor

kellyelton · 2026-03-26T20:13:38Z

🤖 Bot Review: APPROVED — All 3 review levels passed (standard, security, requirements). Ready to merge.

kellyelton · 2026-03-27T18:43:26Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T18:44:26Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Clean _isLoading flag prevents false unsaved state during deck loading

Level 2: Security Review ✅
No security concerns - UI state management fix only

Level 3: Requirements Review ✅
Directly addresses #2028 false unsaved prompt by suppressing state changes during deck loading

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T19:07:12Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T19:09:23Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Clean code with proper state management using _isLoading flag to prevent false unsaved prompts during deck loading.

Level 2: Security Review ✅
No security concerns in UI state management change.

Level 3: Requirements Review ✅
Directly addresses #2028 by suppressing false unsaved prompts during deck loading with proper _isLoading flag.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T20:09:12Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Correctly implements _isLoading flag to prevent false unsaved state during deck loading with proper try/finally cleanup.

Level 2: Security Review ✅
No security concerns - state management fix for deck loading UI, no hardcoded secrets or validation issues.

Level 3: Requirements Review ✅
Addresses issue #2028 by preventing false unsaved changes prompt when loading decks with notes, matching the exact problem described.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T20:43:02Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T20:43:36Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Good try-finally handling, proper _isLoading flag implementation prevents race conditions.

Level 2: Security Review ✅
No security concerns, proper UI state management prevents false positive dirty flags.

Level 3: Requirements Review ✅
Directly addresses issue #2028 by suppressing unsaved changes during deck loading.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T22:23:39Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T22:24:36Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Good try-finally structure, proper state management with _isLoading flag to prevent UI state pollution during loading.

Level 2: Security Review ✅
No security vulnerabilities detected - proper flag-based state management prevents unwanted UI changes.

Level 3: Requirements Review ✅
PR perfectly fixes issue #2028 - prevents false unsaved changes prompt during deck loading by suppressing TextChanged events.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T22:44:05Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T22:45:15Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Good code quality with proper state management and null handling

Level 2: Security Review ✅
No security concerns - UI state management only

Level 3: Requirements Review ✅
Directly addresses #2028 - suppresses false unsaved changes prompt during deck loading

All 3 review levels passed. Ready for merge.

Note: Automated approval not available due to PR ownership constraints. Manual review recommended before merge.

kellyelton · 2026-03-27T22:54:01Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T22:54:52Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Good code quality - adds _isLoading flag to prevent false unsaved changes during deck loading, with proper try-finally cleanup.

Level 2: Security Review ✅
No security concerns - this is a UI state management fix that prevents false dirty flag during deck loading.

Level 3: Requirements Review ✅
Directly addresses issue #2028 - prevents false unsaved changes prompt during deck loading by using _isLoading flag to suppress dirty state.

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T23:41:45Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-27T23:42:17Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Clean bug fix that prevents false unsaved changes during deck loading

Level 2: Security Review ✅
No security concerns; UI logic fix preventing false positive prompts

Level 3: Requirements Review ✅
Directly addresses issue #2028 - prevents false unsaved changes prompt when loading decks

All 3 review levels passed. Ready for merge.

kellyelton · 2026-03-27T23:47:36Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-28T00:26:43Z

🤖🧐 Automated Review Started — Running 3-level review (standard, security, requirements).

kellyelton · 2026-03-28T00:27:24Z

🤖🧐 ✅ Automated Code Review — PASSED

PR: #2297 — Fix #2028: Suppress false unsaved changes prompt when loading a deck
Issue: #2028 — Deck editor sometimes asks about unsaved modification even if a deck wasn't modified

Level 1: Standard Code Review ✅
Added _isLoading flag to prevent false unsaved changes during deck loading.

Level 2: Security Review ✅
No security concerns - safe UI state management fix.

Level 3: Requirements Review ✅
Directly addresses issue #2028 false unsaved changes prompt when loading decks.

All 3 review levels passed. Ready for merge.

Fix #2028: Suppress false unsaved changes prompt when loading a deck …

c676ef4

…in the editor

kellyelton added octgn-issue-bot PRs created by the OCTGN issue bot awaiting-review Awaiting automated review labels Mar 25, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review labels Mar 26, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton commented Mar 27, 2026

View reviewed changes

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added the reviewing PR is currently being reviewed by the automated reviewer label Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added the reviewing PR is currently being reviewed by the automated reviewer label Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton added reviewing PR is currently being reviewed by the automated reviewer and removed awaiting-review Awaiting automated review reviewing PR is currently being reviewed by the automated reviewer labels Mar 27, 2026

kellyelton removed the reviewing PR is currently being reviewed by the automated reviewer label Mar 28, 2026

Uh oh!

Conversation

kellyelton commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kellyelton commented Mar 26, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton left a comment

Choose a reason for hiding this comment

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 27, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

kellyelton commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kellyelton commented Mar 25, 2026 •

edited

Loading